Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC3943: Partial joins to nameless rooms should include heroes' memberships #3943

Merged
merged 4 commits into from
Jan 23, 2023
Merged

MSC3943: Partial joins to nameless rooms should include heroes' memberships #3943

merged 4 commits into from
Jan 23, 2023

Conversation

DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented Dec 2, 2022

@DMRobertson DMRobertson marked this pull request as ready for review December 2, 2022 14:05
@anoadragon453 anoadragon453 added proposal A matrix spec change proposal kind:maintenance MSC which clarifies/updates existing spec needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. labels Dec 2, 2022
@anoadragon453 anoadragon453 changed the title Partial joins to nameless rooms should include heroes' memberships MSC3943: Partial joins to nameless rooms should include heroes' memberships Dec 2, 2022
@turt2live turt2live added the client-server Client-Server API label Dec 2, 2022
@DMRobertson DMRobertson removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label Dec 5, 2022
@erikjohnston
Copy link
Member

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jan 13, 2023

Team member @erikjohnston has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jan 13, 2023
Co-authored-by: Erik Johnston <erikj@jki.re>

## Background

[MSC3706](https://github.com/matrix-org/matrix-spec-proposals/pull/3706) extends the federation `/send_join` endpoint to optionally return a "partial state" response. In this mode of operation, the joining server is given only a _subset_ of the current state[^1] of the room to be joined; the full state is lazily loaded by the joining server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not really a problem in this MSC, though for future MSCs please limit lines to ~100 characters.

@mscbot
Copy link
Collaborator

mscbot commented Jan 17, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jan 17, 2023
@mscbot
Copy link
Collaborator

mscbot commented Jan 22, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Jan 22, 2023
@turt2live turt2live merged commit 26f5eff into matrix-org:main Jan 23, 2023
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Jan 23, 2023
@uhoreg
Copy link
Member

uhoreg commented Jan 31, 2023

Spec PR: matrix-org/matrix-spec#1425

@uhoreg uhoreg added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels Jan 31, 2023
@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Feb 7, 2023
@turt2live
Copy link
Member

Merged 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-server Client-Server API kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Status: Done to some definition
Development

Successfully merging this pull request may close these issues.

6 participants