-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Generic Webhooks Widget interface #140
Conversation
15a92a6
to
f427d89
Compare
video demo looks quite excellent. Q: (how) do you prevent leaking the webhook url to anyone in the room besides the admin? can't anyone use the widget? => is this what the admin room setting is supposed to solve? |
URLs are "secret", so non-admins basically can see the code and the name (i.e. what you can see from the state event). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Admittedly, I've only skimmed the React bits – having them in scope of all this feels a bit overwhelming, but I'm not sure if it makes practical sense to separate it.
This PR improves the general interface around admin room controls for widgets. The outcome will hopefully be mapping the complete set of configuration options and tools to the widget web app.Previously, this PR demoed an experiment to show invite widgets (that eventually became the Slack invite widget experiment). However, invite UI in hookshot isn't particularly useful so it was removed from this PR. This PR now does other things.
matrix-appservice-bridge
's ProvisioningAPI.Video
TODO: