Move webhooks from / to /webhook #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you create an issue and ping me on https://github.com/spantaleev/matrix-docker-ansible-deploy when you merge? |
Half-Shot
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic webhooks router currently listens on
/:hookId/which means that while the request paths are short, it causes confusion when a user misconfigures their bridge and gets a 200 response regardless. This PR makes the bridge prefer/webhook, while still supporting/:hookId.In addition, the bridge now gives an appropriate 404 from both paths when a hookId is not found. The bridge can also be configured to wait until the webhook has finished processing before responding, although this behavior is off by default.