Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub widget #420

Merged
merged 11 commits into from
Jul 29, 2022
Merged

Add GitHub widget #420

merged 11 commits into from
Jul 29, 2022

Conversation

AndrewFerr
Copy link
Member

Also make assorted fixes to help push this along

Depends on #418. Can be split into separate commits if desirable.

Open pre-existing issues (which affect other widgets too):

  • Setting the command prefix via the widget doesn't work.
  • CSS doesn't indent "child" event checkboxes (like Merge Requests->Opened/Closed/...), so they're all laid out in a single list despite having parent-child dependencies.

@AndrewFerr
Copy link
Member Author

Examples:
image
image

@AndrewFerr
Copy link
Member Author

Org names are now shown, which is needed to avoid conflicts between repos with the same name but in different orgs.

image

Half-Shot
Half-Shot requested changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the right path, I just have a few questions

src/ConnectionManager.ts Outdated Show resolved Hide resolved
src/ConnectionManager.ts Outdated Show resolved Hide resolved
web/components/roomConfig/GenericWebhookConfig.tsx Show resolved Hide resolved
@AndrewFerr AndrewFerr requested a review from a team as a code owner July 27, 2022 12:43
Half-Shot
Half-Shot requested changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, then it should be good to go!

src/Connections/GithubRepo.ts Outdated Show resolved Hide resolved
src/Connections/GithubRepo.ts Show resolved Hide resolved
src/Connections/GitlabRepo.ts Outdated Show resolved Hide resolved
@AndrewFerr
Copy link
Member Author

One final (zero-diff) force-push to merge cleanly on the squashed version of #418.

@AndrewFerr AndrewFerr merged commit e961322 into main Jul 29, 2022
@AndrewFerr AndrewFerr deleted the af/github-widgets branch July 29, 2022 14:05
@AndrewFerr AndrewFerr mentioned this pull request Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewFerr @Half-Shot