Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip already handled GitHub events #429

Merged
merged 3 commits into from
Aug 12, 2022

Conversation

Half-Shot
Copy link
Contributor

This is just a simple check to ensure we don't handle multiple events sent by GitHub by looking at the GUID provided. This is already pretty rare, but we've seen this happen rarely in the wild.

GitLab/JIRA don't support this as they don't provide a guid :s

@Half-Shot Half-Shot requested a review from a team as a code owner July 29, 2022 10:51
src/Webhooks.ts Show resolved Hide resolved
src/Webhooks.ts Outdated Show resolved Hide resolved
@Half-Shot Half-Shot requested a review from tadzik August 11, 2022 14:06
@Half-Shot Half-Shot merged commit e487b48 into main Aug 12, 2022
@Half-Shot Half-Shot deleted the hs/ignore-duplicate-github-payloads branch August 12, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants