Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge GitLab MR approvals and comments into one message #484

Merged
merged 6 commits into from
Sep 15, 2022

Conversation

Half-Shot
Copy link
Contributor

Before this change, writing a review and commenting on a MR it would produce two notifications when really most users would expect one. This PR ensures that both comments and approval status are sent as one merged message.

@Half-Shot Half-Shot requested a review from a team as a code owner September 12, 2022 13:03
@Half-Shot Half-Shot changed the title Merge approvals and comments as one comment Merge GitLab MR approvals and comments as one comment Sep 12, 2022
@Half-Shot Half-Shot changed the title Merge GitLab MR approvals and comments as one comment Merge GitLab MR approvals and comments into one message Sep 12, 2022
Copy link
Contributor

@justinbot justinbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments but looks reasonable (linter checks aside)

@Half-Shot Half-Shot enabled auto-merge (squash) September 15, 2022 16:44
@Half-Shot Half-Shot merged commit 5184506 into main Sep 15, 2022
@Half-Shot Half-Shot deleted the hs/merge-approval-comments-gitlab branch September 15, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants