Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GitLab MR comment bodies (optionally) #500

Merged
merged 8 commits into from
Sep 30, 2022
Merged

Support GitLab MR comment bodies (optionally) #500

merged 8 commits into from
Sep 30, 2022

Conversation

Half-Shot
Copy link
Contributor

Fixes #499

@Half-Shot Half-Shot requested a review from a team as a code owner September 29, 2022 11:25
jaller94
jaller94 suggested changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo and wrong variable, other than that

Please avoid weird union types. Looks good to me.

Half-Shot and others added 4 commits September 29, 2022 16:39
@Half-Shot
Update src/Connections/GitlabRepo.ts
26df48f 
Co-authored-by: Christian Paul <christianp@matrix.org>
@Half-Shot
Update docs/usage/room_configuration/gitlab_project.md
5453e45 
Co-authored-by: Christian Paul <christianp@matrix.org>
@Half-Shot
Tweak functions
464458a
@Half-Shot
Merge remote-tracking branch 'origin/hs/support-gitlab-mr-comments' i…
f226b02 
…nto hs/support-gitlab-mr-comments
@Half-Shot Half-Shot requested a review from jaller94 September 29, 2022 15:55
jaller94
jaller94 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Half-Shot Half-Shot merged commit 4c33c60 into main Sep 30, 2022
@Half-Shot Half-Shot deleted the hs/support-gitlab-mr-comments branch September 30, 2022 15:33
This was referenced Oct 3, 2022
Closed
Closed
AndrewFerr added a commit that referenced this pull request Oct 4, 2022
@AndrewFerr
Add changelog
6194653 
Copied from #500's changelog
AndrewFerr added a commit that referenced this pull request Oct 4, 2022
@AndrewFerr
Add changelog
4acf9e1 
Copied from #500's changelog
AndrewFerr added a commit that referenced this pull request Oct 4, 2022
@AndrewFerr
Add label to GitLab widget's comment body toggle (#517)
4d3567b 
* Add label to GitLab widget's comment body toggle

Also ensure that the label is part of the click region

* Add changelog

Copied from #500's changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Gitlab comments in MR Comment events
2 participants
@Half-Shot @jaller94