Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move web tsconfig to let TS language server work #506

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Conversation

AndrewFerr
Copy link
Member

This allows type-checking to work on Preact components used by *.tsx files in the web directory. It works for me in VSCode, vim + YouCompleteMe, and Eclipse + Wild Web Developer.

This also includes an extra commit to fix type errors on imported images, since getting those errprs out of the way makes the most of the errors exposed by the tsconfig move.

@AndrewFerr AndrewFerr self-assigned this Sep 30, 2022
@AndrewFerr AndrewFerr requested a review from a team as a code owner September 30, 2022 05:39
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is much more sensible!

@AndrewFerr AndrewFerr merged commit 911a73a into main Sep 30, 2022
@AndrewFerr AndrewFerr deleted the af/react-tsconfig branch September 30, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants