Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Jira widget request loop for logged-out users #507

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Fix Jira widget request loop for logged-out users #507

merged 2 commits into from
Oct 3, 2022

Conversation

AndrewFerr
Copy link
Member

@AndrewFerr AndrewFerr commented Oct 3, 2022 •
edited
Loading

Without this change, viewing the Jira widget without being logged into Jira causes the widget to repeatedly make network requests.

Note that this intentionally lacks a changelog since it fixes an issue with a yet-to-be-released feature (the Jira widget).

@AndrewFerr AndrewFerr requested a review from Half-Shot October 3, 2022 05:00
@AndrewFerr AndrewFerr requested a review from a team as a code owner October 3, 2022 05:00
@AndrewFerr AndrewFerr self-assigned this Oct 3, 2022
Half-Shot
Half-Shot approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog but otherwise good. If you copy paste the content of your changelog file for the JIRA feature PR, it will merge the two changelog entries into one upon release (to avoid bloating out the changelog file)

@AndrewFerr
Add changelog file
302e706 
(copied from #502)
@AndrewFerr AndrewFerr merged commit 50fa037 into main Oct 3, 2022
@AndrewFerr AndrewFerr deleted the af/jira-widget-request-loop-fix branch October 3, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees

@AndrewFerr AndrewFerr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewFerr @Half-Shot