Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send empty query string in widget API reqs #518

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Don't send empty query string in widget API reqs #518

merged 1 commit into from
Oct 4, 2022

Conversation

AndrewFerr
Copy link
Member

Nitpick change to avoid a trailing ? in /widgetapi/v1/targets/<type> query URLs when not using any filters.

@AndrewFerr AndrewFerr added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements. S-Tolerable Low/no impact on users Widgets / Provisioning Involves the widgets / provisioning subsystem labels Oct 4, 2022
@AndrewFerr AndrewFerr requested a review from Half-Shot October 4, 2022 05:31
@AndrewFerr AndrewFerr self-assigned this Oct 4, 2022
@AndrewFerr AndrewFerr requested a review from a team as a code owner October 4, 2022 05:31
@AndrewFerr AndrewFerr merged commit 31aa5e9 into main Oct 4, 2022
@AndrewFerr AndrewFerr deleted the af/no-empty-query branch October 4, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees

@AndrewFerr AndrewFerr

Labels
S-Tolerable Low/no impact on users T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements. Widgets / Provisioning Involves the widgets / provisioning subsystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewFerr @Half-Shot