Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure unknown keys are retained when connection state is altered via widget #587

Merged
merged 7 commits into from
Dec 8, 2022
Merged

Ensure unknown keys are retained when connection state is altered via widget #587

merged 7 commits into from
Dec 8, 2022

Conversation

Half-Shot
Copy link
Contributor

Fixes #584

This also fixes a few validation bugs in GitHubRepo.

@Half-Shot Half-Shot requested a review from a team as a code owner December 7, 2022 11:45
@Half-Shot Half-Shot enabled auto-merge (squash) December 8, 2022 01:54
@Half-Shot Half-Shot disabled auto-merge December 8, 2022 16:33
@Half-Shot Half-Shot merged commit 0eabb9e into main Dec 8, 2022
@Half-Shot Half-Shot deleted the hs/fixup-github-state-weirdness branch December 8, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadzik tadzik tadzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating connection state via widget after manual edits, will obliterate manual edits.
2 participants
@Half-Shot @tadzik