Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the GitLab instance name when looking for existing connections #617

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Check the GitLab instance name when looking for existing connections #617

merged 2 commits into from
Jan 10, 2023

Conversation

Half-Shot
Copy link
Contributor

We're checking to see if there are multiple connections with the same path in the room, but they might be on different instances!

@Half-Shot Half-Shot requested a review from a team as a code owner January 9, 2023 11:07
jaller94
jaller94 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. so simple. 🤯
Looks good to me.

@Half-Shot Half-Shot merged commit 4048cc8 into main Jan 10, 2023
@Half-Shot Half-Shot deleted the hs/fix-existing-check branch January 10, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @jaller94