Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register namespace for sample serviceBot in registration.sample.yml #643

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

HarHarLinks
Copy link
Contributor

@HarHarLinks HarHarLinks commented Feb 12, 2023

Signed-off-by: Kim Brose 2803622+HarHarLinks@users.noreply.github.com

Context: https://matrix.to/#/!TlZdPIYrhwNvXlBiEk:half-shot.uk/$AdcR43mfQlQq2p97UOgmIZTfUlmBVNbI7CtTQZ6_-74?via=half-shot.uk&via=matrix.org&via=element.io

Sample config

  • disables feeds
  • enables feeds serviceBot
  • does not register feeds serviceBot namespace

This change fixes the latter, thus providing an example for anybody using servicebots.

The spec isn't totally clear that this is needed, but it appears to be this way with synapse. Should the spec be updated to state this requirement more clearly?

Related: #641

@HarHarLinks HarHarLinks requested a review from a team as a code owner February 12, 2023 22:53
@HarHarLinks HarHarLinks changed the title Patch 20 Register namespace for sample serviceBot in registration.sample.yml Feb 12, 2023
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

@Half-Shot Half-Shot enabled auto-merge (squash) February 13, 2023 12:29
@Half-Shot Half-Shot disabled auto-merge February 13, 2023 12:29
@Half-Shot Half-Shot merged commit 1b80bd8 into matrix-org:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants