Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a ready probe to each listener and start the listeners immediately #676

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Add a ready probe to each listener and start the listeners immediately #676

merged 4 commits into from
Mar 24, 2023

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Mar 23, 2023 •
edited
Loading

This should help us out a bit with few small issues:

  • The ready state of each listener is directly mapped to whether it has resources bound, and we apply resources after the application is ready.
  • This allows applications to check whether independent listeners of hookshot are ready.
  • Liveness checks no longer wait for connections to start up...which is currently the case.
  • As a bonus, we no longer logspam each ready check.

@Half-Shot Half-Shot requested a review from a team as a code owner March 23, 2023 11:51
@Half-Shot Half-Shot merged commit 5d27f17 into main Mar 24, 2023
@Half-Shot Half-Shot deleted the hs/ready-probes branch March 24, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadzik tadzik tadzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @tadzik