Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feeds failing metric #681

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Add feeds failing metric #681

merged 4 commits into from
Mar 24, 2023

Conversation

Half-Shot
Copy link
Contributor

A simple counter that lets us see whether we are having HTTP failures or parsing failures, to track relative success when we modify the parser.

@Half-Shot Half-Shot requested a review from a team as a code owner March 24, 2023 11:54
jaller94
jaller94 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Half-Shot Half-Shot enabled auto-merge (squash) March 24, 2023 13:08
@Half-Shot Half-Shot merged commit d12a05d into main Mar 24, 2023
@Half-Shot Half-Shot deleted the hs/feeds-metric branch March 24, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaller94 jaller94 jaller94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @jaller94