Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic Helm chart for Hookshot #719

Merged
merged 16 commits into from
Jun 8, 2023

Conversation

Arkaniad
Copy link
Contributor

This MR adds a basic Hookshot Helm chart alongside the repo.

It uses chart-releaser via GitHub Actions to build / package / release the chart any time the chart's version changes in Chart.yaml. Also includes some brief documentation.

I did not implement chart-testing yet, so there are little assurances attached to the chart at the moment - However, it's simple enough so as to not have presented too many issues thus far and we are using it in production all over the place, so YMMV :)

Signed-off-by: Rhea Danzey <rdanzey@element.io>
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Signed-off-by: Rhea Danzey <rdanzey@element.io>
@Arkaniad Arkaniad added T-Documentation Improvements or additions to documentation T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements. labels Apr 18, 2023
@Arkaniad Arkaniad requested a review from a team as a code owner April 18, 2023 18:38
@Half-Shot
Copy link
Contributor

Thanks so much for the chart, this looks amazing. I'll do a thorough review in the morning, but if you can chuck in a changelog into changelogs.d that'd be a great start.

Signed-off-by: Rhea Danzey <rdanzey@element.io>
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks amazing, and I suspect you know a lot more about what this does than me :D. It's making sense though, just a few queries.

helm/hookshot/README.md Outdated Show resolved Hide resolved
helm/hookshot/templates/NOTES.txt Show resolved Hide resolved
helm/cr.yaml Show resolved Hide resolved
Co-authored-by: Will Hunt <will@half-shot.uk>
@rhizoet
Copy link

rhizoet commented Jun 6, 2023

What's the status on this? We want to use this on our matrix server 😃

@Arkaniad
Copy link
Contributor Author

Arkaniad commented Jun 6, 2023

@rhizoet The chart in this MR branch is fully functional and being used in production :) Just need to iron out some CI / release stuff not related to core chart functionality

@rhizoet
Copy link

rhizoet commented Jun 6, 2023

@rhizoet The chart in this MR branch is fully functional and being used in production :) Just need to iron out some CI / release stuff not related to core chart functionality

Can you release the chart in a repo or anything else to install it easy with helm? That would be very helpful for me.
Yes, I can build it locally and install it. But we use fluxCD and we want to pull it from an "official" source :-)

@Arkaniad
Copy link
Contributor Author

Arkaniad commented Jun 6, 2023

@rhizoet fully sympathise with you and our ArgoCD needs :)

Let me see if I can just put a bow on the remainder here and get it out the door...

@rhizoet
Copy link

rhizoet commented Jun 6, 2023

@Arkaniad thanks a lot. Let me know, if you need some help or anything else.

Arkaniad added 2 commits June 6, 2023 10:41
Signed-off-by: Rhea Danzey <rdanzey@element.io>
…into values

Signed-off-by: Rhea Danzey <rdanzey@element.io>
@Arkaniad
Copy link
Contributor Author

Arkaniad commented Jun 6, 2023

@Half-Shot I think I've got a workable solution for the build pipeline / versioning concerns - if everything looks good can we push this out? 👯

Arkaniad added 2 commits June 6, 2023 10:51
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

.github/workflows/helm.yml Outdated Show resolved Hide resolved
Half-Shot and others added 2 commits June 8, 2023 18:07
@Half-Shot Half-Shot merged commit b102798 into matrix-org:main Jun 8, 2023
Half-Shot added a commit that referenced this pull request Jun 8, 2023
#719 adds helm releases, which we don't need in the docs :)
Half-Shot added a commit that referenced this pull request Jun 8, 2023
#719 adds helm releases, which we don't need in the docs :)
SpiritCroc added a commit to SpiritCroc/matrix-hookshot that referenced this pull request Jun 20, 2023
4.3.0 (2023-06-19)
==================

Features
--------

- Added basic helm chart to repository with GitHub Actions / chart-releaser builds ([\matrix-org#719](matrix-org#719))
- Feeds are now polled concurrently (defaulting to 4 feeds at a time). ([\matrix-org#779](matrix-org#779))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Documentation Improvements or additions to documentation T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants