-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic Helm chart for Hookshot #719
Conversation
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Thanks so much for the chart, this looks amazing. I'll do a thorough review in the morning, but if you can chuck in a changelog into |
Signed-off-by: Rhea Danzey <rdanzey@element.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks amazing, and I suspect you know a lot more about what this does than me :D. It's making sense though, just a few queries.
Co-authored-by: Will Hunt <will@half-shot.uk>
What's the status on this? We want to use this on our matrix server 😃 |
@rhizoet The chart in this MR branch is fully functional and being used in production :) Just need to iron out some CI / release stuff not related to core chart functionality |
Can you release the chart in a repo or anything else to install it easy with helm? That would be very helpful for me. |
@rhizoet fully sympathise with you and our ArgoCD needs :) Let me see if I can just put a bow on the remainder here and get it out the door... |
@Arkaniad thanks a lot. Let me know, if you need some help or anything else. |
Signed-off-by: Rhea Danzey <rdanzey@element.io>
…into values Signed-off-by: Rhea Danzey <rdanzey@element.io>
@Half-Shot I think I've got a workable solution for the build pipeline / versioning concerns - if everything looks good can we push this out? 👯 |
Signed-off-by: Rhea Danzey <rdanzey@element.io>
Signed-off-by: Rhea Danzey <rdanzey@element.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Co-authored-by: Will Hunt <will@half-shot.uk>
#719 adds helm releases, which we don't need in the docs :)
#719 adds helm releases, which we don't need in the docs :)
4.3.0 (2023-06-19) ================== Features -------- - Added basic helm chart to repository with GitHub Actions / chart-releaser builds ([\matrix-org#719](matrix-org#719)) - Feeds are now polled concurrently (defaulting to 4 feeds at a time). ([\matrix-org#779](matrix-org#779))
This MR adds a basic Hookshot Helm chart alongside the repo.
It uses chart-releaser via GitHub Actions to build / package / release the chart any time the chart's version changes in
Chart.yaml
. Also includes some brief documentation.I did not implement chart-testing yet, so there are little assurances attached to the chart at the moment - However, it's simple enough so as to not have presented too many issues thus far and we are using it in production all over the place, so YMMV :)