fix: Make sure that the blockquote markdown for github issue comments are valid commonmark #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MTRNord
changed the title
Half-Shot
approved these changes
May 17, 2023
I already forgot about this one :D will do when I am home 😄 |
auto-merge was automatically disabled
May 18, 2023 10:43
Merge queue setting changed
… are valid commonmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that blockquotes don't get rendered as such. Leading spaces in front of
>are not valid in commonmark. So they get not properly converted, but instead they seem to get escaped.This PR was made on the assumption that the lib used follows commonmark spec as closely as it claims, and this being the logical result for this. I didn't have a test env handy to actually validate this.
Signed-off-by: Marcel Radzio support@nordgedanken.dev