Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply cargo clippy suggestions to reduce not needed allocations #750

Merged
merged 2 commits into from
May 17, 2023

Conversation

MTRNord
Copy link
Contributor

@MTRNord MTRNord commented May 15, 2023

Hi,

I applied the non style related clippy suggestions. (apart from the map_clone one and single_match in some places)

Namely:

I also removed some calls to format! which should be not needed and allocate a String while not needed. (Though I am not sure if napi will do this anyway for FFI)

Signed-off-by: Marcel Radzio support@nordgedanken.dev

@MTRNord MTRNord requested a review from a team as a code owner May 15, 2023 09:31
@Half-Shot Half-Shot merged commit 409a8b8 into matrix-org:main May 17, 2023
@Half-Shot Half-Shot mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants