Fix crash from exceptions in handlers #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
approved these changes
Jun 5, 2023
SpiritCroc
added a commit
to SpiritCroc/matrix-hookshot
that referenced
this pull request
Jun 6, 2023
4.2.0 (2023-06-05) =================== Features -------- - Add support for uploading bot avatar images. ([\matrix-org#767](matrix-org#767)) Bugfixes -------- - Fix confusing case where issue comments would be notified on if the issue event type is checked on GitHub connections. ([\matrix-org#757](matrix-org#757)) - Fix crash when failing to handle events, typically due to lacking permissions to send messages in a room. ([\matrix-org#771](matrix-org#771)) Conflicts: src/Connections/FeedConnection.ts src/feeds/parser.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the whole application crashing when an exception happens in a handler.
Typically this was failing to send a message due to lacking permissions.
This seems like it may have regressed in #754 due to changes wrapping in
Sentry.withScope, which has this caveat:Fixes #769