Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to find an HTML-type link first when parsing atom feeds #784

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Try to find an HTML-type link first when parsing atom feeds #784

merged 2 commits into from
Jun 28, 2023

Conversation

chvp
Copy link
Contributor

@chvp chvp commented Jun 17, 2023

Fixes #781

@chvp chvp requested a review from a team as a code owner June 17, 2023 16:59
@chvp chvp force-pushed the fix-atom-html-links branch from f0d5064 to 52447d6 Compare June 17, 2023 17:02
@chvp
Copy link
Contributor Author

chvp commented Jun 17, 2023

I deployed this patch to my running hookshot, and this fixes the issue I was experiencing in #781.

Half-Shot
Half-Shot approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a signoff!

(And you need to appease Clippy ^^)

@chvp
Try to find an HTML-type link first when parsing atom feeds
0cab83a 
Signed-off-by: Charlotte Van Petegem <charlotte@vanpetegem.me>
@chvp chvp force-pushed the fix-atom-html-links branch from 52447d6 to 0cab83a Compare June 22, 2023 12:38
@chvp
Copy link
Contributor Author

chvp commented Jun 22, 2023

Done and done. Thanks for the review!

@chvp chvp requested a review from Half-Shot June 22, 2023 12:41
@Half-Shot Half-Shot enabled auto-merge June 28, 2023 15:30
@Half-Shot Half-Shot added this pull request to the merge queue Jun 28, 2023
Merged via the queue into matrix-org:main with commit 4351a37 Jun 28, 2023
@chvp chvp deleted the fix-atom-html-links branch June 28, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Awaiting requested review from Half-Shot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select link with type="text/html" from RSS feed if there are multiple links
2 participants
@chvp @Half-Shot