-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create alertmanager.js #808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this one :). Just a couple of requests from me.
@HarHarLinks Could you please add some spaces and a slash for improved formatting? This is how it looks. This is how an alarm looks with spaces and a slash added. |
@erebion thanks for the screenshots. |
@HarHarLinks Sure, I modified this slightly to look better so I can tell you what I did. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes pls to improve formatting :)
I refactored @erebion's suggestions slightly, and kept to a bit more compact message. please resolve the review threads if you're happy with that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy, will give @erebion a bit of time to respond.
Looks okay, though I'd be a bit happier with an additional line break after Many people struggle to read such messages if they are a wall of text and have a much easier time if there's a line break. Also, I think it looks a bit better. |
could someone who is actually running this please test if my replaceAll works properly? |
convert `\n` line breaks to html `<br/>` so the upstream formatting is applied
Signed-off-by: Kim Brose 2803622+HarHarLinks@users.noreply.github.com