Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about scope for private vs. public repo notifications #830

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Add note about scope for private vs. public repo notifications #830

merged 3 commits into from
Oct 24, 2023

Conversation

Twi1ightSparkle
Copy link
Contributor

In hindsight it's very obvious that it need repo to get issue comments and other details for notifications from private repos, but it took me way to much time to think of that.

And, repo:status is above public_repo on the list of token permissions.

@Twi1ightSparkle Twi1ightSparkle requested a review from a team as a code owner October 17, 2023 10:00
Half-Shot
Half-Shot approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Half-Shot Half-Shot added this pull request to the merge queue Oct 24, 2023
Merged via the queue into matrix-org:main with commit 527f6aa Oct 24, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Half-Shot Half-Shot Half-Shot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Twi1ightSparkle @Half-Shot