Fix challengehound duplication bug. #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpiritCroc
added a commit
to SpiritCroc/matrix-hookshot
that referenced
this pull request
Nov 29, 2024
- Add support for setting an expiry time on a webhook. See the documentation on [Generic Webhooks](https://matrix-org.github.io/matrix-hookshot/latest/setup/webhooks.html) for more information. ([\matrix-org#984](matrix-org#984)) - Support for E2E Encrypted rooms is now considered stable and can be enabled in production. Please see the [documentation](https://matrix-org.github.io/matrix-hookshot/latest/advanced/encryption.html) on the requirements for enabling support. ([\matrix-org#989](matrix-org#989)) - Fix Challenge Hound activities being duplicated if the cache layer (e.g Redis) goes away. ([\matrix-org#982](matrix-org#982)) - Drop support for Node 20 and start supporting Node 22, 23. ([\matrix-org#990](matrix-org#990)) - Reduce bundle size of widget. ([\matrix-org#985](matrix-org#985)) - Don't invoke newsfile CI check for dependabot. ([\matrix-org#987](matrix-org#987)) - Add devenv development files. ([\matrix-org#993](matrix-org#993)) - Push Docker images to ghcr.io, and and build an image on each commit. ([\matrix-org#994](matrix-org#994)) - Retry e2e tests in CI due to container creation flakiness. ([\matrix-org#995](matrix-org#995)) - Update matrix-bot-sdk to pull in new matrix-rust-sdk. ([\matrix-org#996](matrix-org#996))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #981
If we haven't got anything in storage for challengehound, then it defaults to emitting everything to the room. This is a problem for memory-storage bots or unreliable Redis stores. To fix this, simply do not emit anything on first poll.
This also fixes a problem where we were endlessly adding the same hashes to Redis, using up more storage than required.