Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix cross signing setup from settings screen #6633

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Fix cross signing setup from settings screen #6633

merged 1 commit into from
Aug 23, 2021

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Aug 18, 2021 •
edited by github-actions bot
Loading

We previously called bootstrap without the cache callbacks set up
which meant it prompted you for you password once for each of the
three keys it fished out of SSSS. Instead, display the same dialog
we display from the verify toast.

Also, in the case where you hadn't verified yet, the button didn't
do anything at all, so make it trigger a verification & change the
caption appropriately.

Add a state to reflect when cross signing is set up but SSSS isn't
(ie. user hasn't yet set up backup / set a passphrase).

Fixes element-hq/element-web#17761
Type: defect

Screenshot 2021-08-18 at 18 53 53

Screenshot 2021-08-18 at 18 54 01

Screenshot 2021-08-18 at 19 21 39

Screenshot 2021-08-18 at 19 07 58

Here's what your changelog entry will look like:

🐛 Bug Fixes

Preview: https://611d51d21916c900ed4a846e--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@dbkr
Fix cross sisgning setup from settings screen
08b37eb 
We previously called bootstrap without the cache callbacks set up
which meant it prompted you for you password once for each of the
three keys it fished out of SSSS. Instead, display the same dialog
we display from the verify toast.

Also, in the case where you hadn't verified yet, the button didn't
do anything at all, so make it trigger a verification & change the
caption appropriately.

Add a state to reflect when cross signing is set up but SSSS isn't
(ie. user hasn't yet set up backup / set a passphrase).
@dbkr dbkr requested a review from a team as a code owner August 18, 2021 18:27
@github-actions github-actions bot added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Aug 18, 2021
@dbkr dbkr requested a review from amshakal August 18, 2021 18:29
turt2live
turt2live approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems sensible, though all of the SSSS/Cross-Signing magic callbacks terrify me.

src/components/views/settings/CrossSigningPanel.tsx
summarisedStatus = <p>✅ { _t(
"Cross-signing is ready for use.",
) }</p>;
} else if (crossSigningReady && !crossSigningPrivateKeysInStorage) {
summarisedStatus = <p>⚠️ { _t(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emoji should be in the string for RTL language translation, unless we consider this a design constraint.

@amshakal
Copy link

This looks fine from the design end as it makes the flows more consistent. A quick question: is there a reason why some buttons are left aligned and some right aligned?

@dbkr
Copy link
Member Author

dbkr commented Aug 20, 2021

The ones in the dialogs are right-aligned but the the left-aligned ones are just in the settings panel.

@amshakal
Copy link

Ah of course, sorry, I got a little confused ^_^

@dbkr dbkr merged commit 5344b86 into develop Aug 23, 2021
@dbkr dbkr deleted the dbkr/fix_cross_signing_setup_settings branch August 23, 2021 08:41
BBaoVanC added a commit to boba-best/element.boba.best that referenced this pull request Aug 24, 2021
@BBaoVanC
Merge tag 'v1.8.2-rc.1' into build
d95594a 
* Documentation for sentry config ([\element-hq#18608](element-hq#18608)). Contributed by [novocaine](https://github.com/novocaine).
* Add a warning on E2EE rooms if you try to make them public ([\element-hq#5698](matrix-org/matrix-react-sdk#5698)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Allow pagination of the space hierarchy and use new APIs ([\element-hq#6507](matrix-org/matrix-react-sdk#6507)). Fixes element-hq#18089 and element-hq#18427.
* Improve emoji in composer ([\element-hq#6650](matrix-org/matrix-react-sdk#6650)). Fixes element-hq#18593 and element-hq#18593. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Allow playback of replied-to voice message ([\element-hq#6629](matrix-org/matrix-react-sdk#6629)). Fixes element-hq#18599 and element-hq#18599. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Format autocomplete suggestions vertically ([\element-hq#6620](matrix-org/matrix-react-sdk#6620)). Fixes element-hq#17574 and element-hq#17574. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Remember last `MemberList` search query per-room ([\#6640](matrix-org/matrix-react-sdk#6640)). Fixes element-hq#18613 and element-hq#18613. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Sentry rageshakes ([\element-hq#6597](matrix-org/matrix-react-sdk#6597)). Fixes element-hq#11111 and element-hq#11111. Contributed by [novocaine](https://github.com/novocaine).
* Autocomplete has been updated to match modern accessibility standards. Navigate via up/down arrows rather than Tab. Enter or Tab to confirm a suggestion. This should be familiar to Slack & Discord users. You can now use Tab to navigate around the application and do more without touching your mouse. No more accidentally sending half of people's names because the completion didn't fire on Enter! ([\element-hq#5659](matrix-org/matrix-react-sdk#5659)). Fixes element-hq#4872, element-hq#11071, element-hq#17171, element-hq#15646 element-hq#4872 and element-hq#4872.
* Add new call tile states ([\element-hq#6610](matrix-org/matrix-react-sdk#6610)). Fixes element-hq#18521 and element-hq#18521. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Left align call tiles ([\element-hq#6609](matrix-org/matrix-react-sdk#6609)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Make loading encrypted images look snappier ([\element-hq#6590](matrix-org/matrix-react-sdk#6590)). Fixes element-hq#17878 and element-hq#17862. Contributed by [Palid](https://github.com/Palid).
* Offer a way to create a space based on existing community ([\element-hq#6543](matrix-org/matrix-react-sdk#6543)). Fixes element-hq#18092.
* Accessibility improvements in and around Spaces ([\element-hq#6569](matrix-org/matrix-react-sdk#6569)). Fixes element-hq#18094 and element-hq#18094.
* Fix images not rendering when sent from other clients. ([\#6661](matrix-org/matrix-react-sdk#6661)). Fixes element-hq#18702 and element-hq#18702.
* Fix autocomplete scrollbar and make the autocomplete a little smaller ([\element-hq#6655](matrix-org/matrix-react-sdk#6655)). Fixes element-hq#18682 and element-hq#18682. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix replies on the bubble layout ([\element-hq#6451](matrix-org/matrix-react-sdk#6451)). Fixes element-hq#18184. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Show "Enable encryption in settings" only when the user can do that ([\element-hq#6646](matrix-org/matrix-react-sdk#6646)). Fixes element-hq#18646 and element-hq#18646. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix cross signing setup from settings screen ([\element-hq#6633](matrix-org/matrix-react-sdk#6633)). Fixes element-hq#17761 and element-hq#17761.
* Fix call tiles on the bubble layout ([\element-hq#6647](matrix-org/matrix-react-sdk#6647)). Fixes element-hq#18648 and element-hq#18648. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix error on accessing encrypted media without encryption keys ([\element-hq#6625](matrix-org/matrix-react-sdk#6625)). Contributed by [Palid](https://github.com/Palid).
* Fix jitsi widget sometimes being permanently stuck in the bottom-right corner ([\#6632](matrix-org/matrix-react-sdk#6632)). Fixes element-hq#17226 and element-hq#17226. Contributed by [Palid](https://github.com/Palid).
* Fix FilePanel pagination in E2EE rooms ([\element-hq#6630](matrix-org/matrix-react-sdk#6630)). Fixes element-hq#18415 and element-hq#18415. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix call tile buttons ([\element-hq#6624](matrix-org/matrix-react-sdk#6624)). Fixes element-hq#18565 and element-hq#18565. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix vertical call tile spacing issues ([\element-hq#6621](matrix-org/matrix-react-sdk#6621)). Fixes element-hq#18558 and element-hq#18558. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix long display names in call tiles ([\element-hq#6618](matrix-org/matrix-react-sdk#6618)). Fixes element-hq#18562 and element-hq#18562. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Avoid access token overflow ([\element-hq#6616](matrix-org/matrix-react-sdk#6616)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Properly handle media errors  ([\element-hq#6615](matrix-org/matrix-react-sdk#6615)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix glare related regressions ([\element-hq#6614](matrix-org/matrix-react-sdk#6614)). Fixes element-hq#18538 and element-hq#18538. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix long display names in call toasts ([\element-hq#6617](matrix-org/matrix-react-sdk#6617)). Fixes element-hq#18557 and element-hq#18557. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix PiP of held calls ([\element-hq#6611](matrix-org/matrix-react-sdk#6611)). Fixes element-hq#18539 and element-hq#18539. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix call tile behaviour on narrow layouts ([\element-hq#6556](matrix-org/matrix-react-sdk#6556)). Fixes element-hq#18398. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix video call persisting when widget removed ([\element-hq#6608](matrix-org/matrix-react-sdk#6608)). Fixes element-hq#15703 and element-hq#15703.
* Fix toast colors ([\#6606](matrix-org/matrix-react-sdk#6606)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Remove tiny scrollbar dot from code blocks ([\element-hq#6596](matrix-org/matrix-react-sdk#6596)). Fixes element-hq#18474. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve handling of pills in the composer ([\element-hq#6353](matrix-org/matrix-react-sdk#6353)). Fixes element-hq#10134 element-hq#10896 and element-hq#15037. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
williamkray added a commit to williamkray/element-web that referenced this pull request Aug 31, 2021
@williamkray
Merge tag 'v1.8.2' into develop
2281fad 
* Documentation for sentry config ([\element-hq#18608](element-hq#18608)). Contributed by [novocaine](https://github.com/novocaine).
* [Release]Increase general app performance by optimizing layers ([\element-hq#6672](matrix-org/matrix-react-sdk#6672)). Fixes element-hq#18730 and element-hq#18730. Contributed by [Palid](https://github.com/Palid).
* Add a warning on E2EE rooms if you try to make them public ([\element-hq#5698](matrix-org/matrix-react-sdk#5698)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Allow pagination of the space hierarchy and use new APIs ([\element-hq#6507](matrix-org/matrix-react-sdk#6507)). Fixes element-hq#18089 and element-hq#18427.
* Improve emoji in composer ([\element-hq#6650](matrix-org/matrix-react-sdk#6650)). Fixes element-hq#18593 and element-hq#18593. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Allow playback of replied-to voice message ([\element-hq#6629](matrix-org/matrix-react-sdk#6629)). Fixes element-hq#18599 and element-hq#18599. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Format autocomplete suggestions vertically ([\element-hq#6620](matrix-org/matrix-react-sdk#6620)). Fixes element-hq#17574 and element-hq#17574. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Remember last `MemberList` search query per-room ([\#6640](matrix-org/matrix-react-sdk#6640)). Fixes element-hq#18613 and element-hq#18613. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Sentry rageshakes ([\element-hq#6597](matrix-org/matrix-react-sdk#6597)). Fixes element-hq#11111 and element-hq#11111. Contributed by [novocaine](https://github.com/novocaine).
* Autocomplete has been updated to match modern accessibility standards. Navigate via up/down arrows rather than Tab. Enter or Tab to confirm a suggestion. This should be familiar to Slack & Discord users. You can now use Tab to navigate around the application and do more without touching your mouse. No more accidentally sending half of people's names because the completion didn't fire on Enter! ([\element-hq#5659](matrix-org/matrix-react-sdk#5659)). Fixes element-hq#4872, element-hq#11071, element-hq#17171, element-hq#15646 element-hq#4872 and element-hq#4872.
* Add new call tile states ([\element-hq#6610](matrix-org/matrix-react-sdk#6610)). Fixes element-hq#18521 and element-hq#18521. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Left align call tiles ([\element-hq#6609](matrix-org/matrix-react-sdk#6609)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Make loading encrypted images look snappier ([\element-hq#6590](matrix-org/matrix-react-sdk#6590)). Fixes element-hq#17878 and element-hq#17862. Contributed by [Palid](https://github.com/Palid).
* Offer a way to create a space based on existing community ([\element-hq#6543](matrix-org/matrix-react-sdk#6543)). Fixes element-hq#18092.
* Accessibility improvements in and around Spaces ([\element-hq#6569](matrix-org/matrix-react-sdk#6569)). Fixes element-hq#18094 and element-hq#18094.
* [Release] Fix commit edit history ([\element-hq#6690](matrix-org/matrix-react-sdk#6690)). Fixes element-hq#18742 and element-hq#18742. Contributed by [Palid](https://github.com/Palid).
* Fix images not rendering when sent from other clients. ([\#6661](matrix-org/matrix-react-sdk#6661)). Fixes element-hq#18702 and element-hq#18702.
* Fix autocomplete scrollbar and make the autocomplete a little smaller ([\element-hq#6655](matrix-org/matrix-react-sdk#6655)). Fixes element-hq#18682 and element-hq#18682. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix replies on the bubble layout ([\element-hq#6451](matrix-org/matrix-react-sdk#6451)). Fixes element-hq#18184. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Show "Enable encryption in settings" only when the user can do that ([\element-hq#6646](matrix-org/matrix-react-sdk#6646)). Fixes element-hq#18646 and element-hq#18646. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix cross signing setup from settings screen ([\element-hq#6633](matrix-org/matrix-react-sdk#6633)). Fixes element-hq#17761 and element-hq#17761.
* Fix call tiles on the bubble layout ([\element-hq#6647](matrix-org/matrix-react-sdk#6647)). Fixes element-hq#18648 and element-hq#18648. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix error on accessing encrypted media without encryption keys ([\element-hq#6625](matrix-org/matrix-react-sdk#6625)). Contributed by [Palid](https://github.com/Palid).
* Fix jitsi widget sometimes being permanently stuck in the bottom-right corner ([\#6632](matrix-org/matrix-react-sdk#6632)). Fixes element-hq#17226 and element-hq#17226. Contributed by [Palid](https://github.com/Palid).
* Fix FilePanel pagination in E2EE rooms ([\element-hq#6630](matrix-org/matrix-react-sdk#6630)). Fixes element-hq#18415 and element-hq#18415. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix call tile buttons ([\element-hq#6624](matrix-org/matrix-react-sdk#6624)). Fixes element-hq#18565 and element-hq#18565. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix vertical call tile spacing issues ([\element-hq#6621](matrix-org/matrix-react-sdk#6621)). Fixes element-hq#18558 and element-hq#18558. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix long display names in call tiles ([\element-hq#6618](matrix-org/matrix-react-sdk#6618)). Fixes element-hq#18562 and element-hq#18562. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Avoid access token overflow ([\element-hq#6616](matrix-org/matrix-react-sdk#6616)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Properly handle media errors  ([\element-hq#6615](matrix-org/matrix-react-sdk#6615)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix glare related regressions ([\element-hq#6614](matrix-org/matrix-react-sdk#6614)). Fixes element-hq#18538 and element-hq#18538. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix long display names in call toasts ([\element-hq#6617](matrix-org/matrix-react-sdk#6617)). Fixes element-hq#18557 and element-hq#18557. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix PiP of held calls ([\element-hq#6611](matrix-org/matrix-react-sdk#6611)). Fixes element-hq#18539 and element-hq#18539. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix call tile behaviour on narrow layouts ([\element-hq#6556](matrix-org/matrix-react-sdk#6556)). Fixes element-hq#18398. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix video call persisting when widget removed ([\element-hq#6608](matrix-org/matrix-react-sdk#6608)). Fixes element-hq#15703 and element-hq#15703.
* Fix toast colors ([\#6606](matrix-org/matrix-react-sdk#6606)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Remove tiny scrollbar dot from code blocks ([\element-hq#6596](matrix-org/matrix-react-sdk#6596)). Fixes element-hq#18474. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve handling of pills in the composer ([\element-hq#6353](matrix-org/matrix-react-sdk#6353)). Fixes element-hq#10134 element-hq#10896 and element-hq#15037. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
BBaoVanC added a commit to boba-best/element.boba.best that referenced this pull request Aug 31, 2021
@BBaoVanC
Merge tag 'v1.8.2' into build
1d06c91 
* Documentation for sentry config ([\element-hq#18608](element-hq#18608)). Contributed by [novocaine](https://github.com/novocaine).
* [Release]Increase general app performance by optimizing layers ([\element-hq#6672](matrix-org/matrix-react-sdk#6672)). Fixes element-hq#18730 and element-hq#18730. Contributed by [Palid](https://github.com/Palid).
* Add a warning on E2EE rooms if you try to make them public ([\element-hq#5698](matrix-org/matrix-react-sdk#5698)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Allow pagination of the space hierarchy and use new APIs ([\element-hq#6507](matrix-org/matrix-react-sdk#6507)). Fixes element-hq#18089 and element-hq#18427.
* Improve emoji in composer ([\element-hq#6650](matrix-org/matrix-react-sdk#6650)). Fixes element-hq#18593 and element-hq#18593. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Allow playback of replied-to voice message ([\element-hq#6629](matrix-org/matrix-react-sdk#6629)). Fixes element-hq#18599 and element-hq#18599. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Format autocomplete suggestions vertically ([\element-hq#6620](matrix-org/matrix-react-sdk#6620)). Fixes element-hq#17574 and element-hq#17574. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Remember last `MemberList` search query per-room ([\#6640](matrix-org/matrix-react-sdk#6640)). Fixes element-hq#18613 and element-hq#18613. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Sentry rageshakes ([\element-hq#6597](matrix-org/matrix-react-sdk#6597)). Fixes element-hq#11111 and element-hq#11111. Contributed by [novocaine](https://github.com/novocaine).
* Autocomplete has been updated to match modern accessibility standards. Navigate via up/down arrows rather than Tab. Enter or Tab to confirm a suggestion. This should be familiar to Slack & Discord users. You can now use Tab to navigate around the application and do more without touching your mouse. No more accidentally sending half of people's names because the completion didn't fire on Enter! ([\element-hq#5659](matrix-org/matrix-react-sdk#5659)). Fixes element-hq#4872, element-hq#11071, element-hq#17171, element-hq#15646 element-hq#4872 and element-hq#4872.
* Add new call tile states ([\element-hq#6610](matrix-org/matrix-react-sdk#6610)). Fixes element-hq#18521 and element-hq#18521. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Left align call tiles ([\element-hq#6609](matrix-org/matrix-react-sdk#6609)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Make loading encrypted images look snappier ([\element-hq#6590](matrix-org/matrix-react-sdk#6590)). Fixes element-hq#17878 and element-hq#17862. Contributed by [Palid](https://github.com/Palid).
* Offer a way to create a space based on existing community ([\element-hq#6543](matrix-org/matrix-react-sdk#6543)). Fixes element-hq#18092.
* Accessibility improvements in and around Spaces ([\element-hq#6569](matrix-org/matrix-react-sdk#6569)). Fixes element-hq#18094 and element-hq#18094.
* [Release] Fix commit edit history ([\element-hq#6690](matrix-org/matrix-react-sdk#6690)). Fixes element-hq#18742 and element-hq#18742. Contributed by [Palid](https://github.com/Palid).
* Fix images not rendering when sent from other clients. ([\#6661](matrix-org/matrix-react-sdk#6661)). Fixes element-hq#18702 and element-hq#18702.
* Fix autocomplete scrollbar and make the autocomplete a little smaller ([\element-hq#6655](matrix-org/matrix-react-sdk#6655)). Fixes element-hq#18682 and element-hq#18682. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix replies on the bubble layout ([\element-hq#6451](matrix-org/matrix-react-sdk#6451)). Fixes element-hq#18184. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Show "Enable encryption in settings" only when the user can do that ([\element-hq#6646](matrix-org/matrix-react-sdk#6646)). Fixes element-hq#18646 and element-hq#18646. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix cross signing setup from settings screen ([\element-hq#6633](matrix-org/matrix-react-sdk#6633)). Fixes element-hq#17761 and element-hq#17761.
* Fix call tiles on the bubble layout ([\element-hq#6647](matrix-org/matrix-react-sdk#6647)). Fixes element-hq#18648 and element-hq#18648. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix error on accessing encrypted media without encryption keys ([\element-hq#6625](matrix-org/matrix-react-sdk#6625)). Contributed by [Palid](https://github.com/Palid).
* Fix jitsi widget sometimes being permanently stuck in the bottom-right corner ([\#6632](matrix-org/matrix-react-sdk#6632)). Fixes element-hq#17226 and element-hq#17226. Contributed by [Palid](https://github.com/Palid).
* Fix FilePanel pagination in E2EE rooms ([\element-hq#6630](matrix-org/matrix-react-sdk#6630)). Fixes element-hq#18415 and element-hq#18415. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix call tile buttons ([\element-hq#6624](matrix-org/matrix-react-sdk#6624)). Fixes element-hq#18565 and element-hq#18565. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix vertical call tile spacing issues ([\element-hq#6621](matrix-org/matrix-react-sdk#6621)). Fixes element-hq#18558 and element-hq#18558. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix long display names in call tiles ([\element-hq#6618](matrix-org/matrix-react-sdk#6618)). Fixes element-hq#18562 and element-hq#18562. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Avoid access token overflow ([\element-hq#6616](matrix-org/matrix-react-sdk#6616)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Properly handle media errors  ([\element-hq#6615](matrix-org/matrix-react-sdk#6615)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix glare related regressions ([\element-hq#6614](matrix-org/matrix-react-sdk#6614)). Fixes element-hq#18538 and element-hq#18538. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix long display names in call toasts ([\element-hq#6617](matrix-org/matrix-react-sdk#6617)). Fixes element-hq#18557 and element-hq#18557. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix PiP of held calls ([\element-hq#6611](matrix-org/matrix-react-sdk#6611)). Fixes element-hq#18539 and element-hq#18539. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix call tile behaviour on narrow layouts ([\element-hq#6556](matrix-org/matrix-react-sdk#6556)). Fixes element-hq#18398. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Fix video call persisting when widget removed ([\element-hq#6608](matrix-org/matrix-react-sdk#6608)). Fixes element-hq#15703 and element-hq#15703.
* Fix toast colors ([\#6606](matrix-org/matrix-react-sdk#6606)). Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Remove tiny scrollbar dot from code blocks ([\element-hq#6596](matrix-org/matrix-react-sdk#6596)). Fixes element-hq#18474. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
* Improve handling of pills in the composer ([\element-hq#6353](matrix-org/matrix-react-sdk#6353)). Fixes element-hq#10134 element-hq#10896 and element-hq#15037. Contributed by [SimonBrandner](https://github.com/SimonBrandner).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@turt2live turt2live turt2live approved these changes

@amshakal amshakal Awaiting requested review from amshakal

Assignees
No one assigned
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'set up' in cross signing settings on unverified device prompts for passphrase three times
3 participants
@dbkr @amshakal @turt2live