Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InvisibleCrypto | Share Room Keys: new RoomKeyShareStrategy based on user identities instead of per device #3563

Closed
BillCarsonFr opened this issue Jun 17, 2024 · 0 comments · Fixed by #3607
Closed

InvisibleCrypto | Share Room Keys: new RoomKeyShareStrategy based on user identities instead of per device #3563

BillCarsonFr opened this issue Jun 17, 2024 · 0 comments · Fixed by #3607
Assignees
@BillCarsonFr
Labels
encryption

Comments

@BillCarsonFr
Copy link
Member

BillCarsonFr commented Jun 17, 2024 •
edited by richvdh
Loading

Follow up of #3562
Part of matrix-org/matrix-spec-proposals#4153.

Introduce a new strategy to collect recipients for room_keys.
New strategy will consider user identities and only distribute to devices signed by their owner

Notes from https://github.com/element-hq/crypto-internal/issues/307:

Introduce a new implementation of the new RoomKeyShareStrategy trait based on Indentities instead of the existing one based on devices. + tests
@BillCarsonFr BillCarsonFr changed the title Share Room Keys | Invisible Crypto new RoomKeyShareStrategy based on user identities instead of per device Share Room Keys | InvisibleCrypto new RoomKeyShareStrategy based on user identities instead of per device Jun 17, 2024
@BillCarsonFr BillCarsonFr mentioned this issue Jun 17, 2024
Closed
@BillCarsonFr BillCarsonFr self-assigned this Jun 18, 2024
@BillCarsonFr BillCarsonFr mentioned this issue Jun 25, 2024
Merged
1 task
@richvdh richvdh changed the title Share Room Keys | InvisibleCrypto new RoomKeyShareStrategy based on user identities instead of per device InvisibleCrypto | Share Room Keys: new RoomKeyShareStrategy based on user identities instead of per device Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillCarsonFr BillCarsonFr

Labels
encryption
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sdk-crypto): Add Identity based room key sharing strategy matrix-org/matrix-rust-sdk
1 participant
@BillCarsonFr