Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/join/{roomId} mixes query-params and POST request #720

Open
richvdh opened this issue Nov 16, 2020 · 1 comment
Open

/join/{roomId} mixes query-params and POST request #720

richvdh opened this issue Nov 16, 2020 · 1 comment
Labels
improvement An idea/future MSC for the spec

Comments

@richvdh
Copy link
Member

richvdh commented Nov 16, 2020

/_matrix/client/r0/join/{roomIdOrAlias} is a POST request which also specifies that server_name can be passed via query-parameters. This sort of mixing of query-parameters with params passed in the request body is a bit odd.

(It turns out that one reason it was done this way was because synapse naughtily uses the /join request body as the content of the join event: matrix-org/synapse#8763)
@richvdh richvdh mentioned this issue Nov 16, 2020
Open
@richvdh richvdh mentioned this issue Nov 26, 2020
Open
@richvdh richvdh transferred this issue from matrix-org/matrix-spec-proposals Mar 1, 2022
@turt2live turt2live added the improvement An idea/future MSC for the spec label May 31, 2022
@richvdh
Copy link
Member Author

richvdh commented Mar 14, 2023

related: #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement An idea/future MSC for the spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@turt2live @richvdh