-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify email invite process #755
Comments
ftr this is all mandated by spec, so the fix here would be to "not do that", whatever that entails. |
seems closely related to element-hq/element-meta#1847 (and any number of other open issues on element-web) |
It would really, really, really be great if we could fix that. |
One problem with the current 3PID-invite is that it depends on having an IS which should be optional afaik. A naïve proposal:
|
This sounds like the homeserver is just another IS. I see no reason to bundle them together. (Although I agree that the user should be offered a default IS choice, whether that is by the homeserver or by the client (or both) I don't know what is better)
This sounds good. This would also be a nice use for password/token join rules. You can send the token in the email and the user can join with an existing account or create a new account and join.
If we use a token there is no need to knock.
If we go token it would be cool to include this in the link to skip the knock! |
There is the central one which is - you know - centralized. There is sydent which isn't supposed to be self-hosted and ma1sd which is not officially supported/endorsed. Also as the HS already has the information there is no reason to involve another system just for that functionality. For our use-case (internal chat in our organization) invite-colleague-by-mail is the only needed feature that depends on an IS.
Nice idea! I've searched around and found a spec issue and an element-web issue requesting this. |
The HS doesn't necessarily know the users email. It is often asked (usually for account recovery) but is often not required. I'm not saying that the HS can't offer an identity server, but I don't see the need for another protocol and wouldn't want to require using the homeserver's identity server. |
In a corporate setup you usually have an external identity provider which also provides 3PIDs. This would not be another protocol. It would just mean adding a line to the spec which says |
I think we are talking past each other because I misunderstood what you meant:
The HS doesn't know 3PIDs but I assume here you mean if the identity server doesn't return a 3PID right? In that case I think the rest of the flow makes sense. Basically instead of getting the IS to send the invite the homeserver just issues the invite directly. Is that what you meant? |
Sorry for the unclear wording. I don't use an IS but can still set e-mail addresses for my account. So my HS knows which e-mail addresses are associated with my account. In our organization the SSO-attribute-mapping actually sets the e-mail for all accounts when they are created. So for every |
This is annoying:
The text was updated successfully, but these errors were encountered: