Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module doesn't follow the Synapse logging context rules #128

Open
squahtx opened this issue Oct 19, 2021 · 1 comment
Open

Module doesn't follow the Synapse logging context rules #128

squahtx opened this issue Oct 19, 2021 · 1 comment

Comments

@squahtx
Copy link
Contributor

squahtx commented Oct 19, 2021

The code in this module doesn't appear to follow the Synapse logging context rules (https://matrix-org.github.io/synapse/latest/log_contexts.html) and drops logging contexts everywhere.

@squahtx
Copy link
Contributor Author

squahtx commented Apr 11, 2022

This is making it difficult to understand logs in bug reports, eg. matrix-org/synapse#10397 (comment) matrix-org/synapse#12456 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant