Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when permalink event ID is not found on page #124

Open
MadLittleMods opened this issue Nov 3, 2022 · 2 comments
Open

Add warning when permalink event ID is not found on page #124

MadLittleMods opened this issue Nov 3, 2022 · 2 comments
Labels
A-archive-room-view The view to look at a room day by day in the archive T-Enhancement New feature or request

Comments

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Nov 3, 2022

Follow-up to #4

Considerations

What happens if the eventId isn't found on that given day?

  • With Gitter, we can easily lookup the eventId and redirect people to the correct day. But I don't think I want to do all of those round-trips to the homeserver to do this sort of thing.
  • In the Matrix public archives, I think I am just going to see if the event is in the given date displayed and if not, put a little warning overlay under the room header which says "Event wasn't found on this day" and link to /:roomIdOrAlias/event/:eventId which will actually do redirection work. This way, it's a choice by the user to take the action to jump to the correct day and it's explained what happened.

Dev notes

Potential language: "It looks like we lost your position or you were given an incorrect link"

Could we tell our fault from someone giving a wrong link? Maybe by looking if the referrer is the /jump endpoint.

@MadLittleMods MadLittleMods added T-Enhancement New feature or request A-archive-room-view The view to look at a room day by day in the archive labels Nov 3, 2022
@nsundriyal62
Copy link

i want to on this issue. please assign this to me?

@bkil

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-archive-room-view The view to look at a room day by day in the archive T-Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants