Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

A room with an unknown room version breaks the spaces summary endpoint #10724

Closed
clokep opened this issue Aug 31, 2021 · 1 comment · Fixed by #10727
Closed

A room with an unknown room version breaks the spaces summary endpoint #10724

clokep opened this issue Aug 31, 2021 · 1 comment · Fixed by #10727
Assignees
@clokep
Labels
A-Spaces Hierarchical organization of rooms S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@clokep
Copy link
Member

clokep commented Aug 31, 2021

From @BillCarsonFr:

it looks like I have a space that contains a room with a deleted room version, and in this case the pagination breaks

not sure what would be expected

image
@clokep clokep added S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. A-Spaces Hierarchical organization of rooms labels Aug 31, 2021
@clokep clokep self-assigned this Aug 31, 2021
@clokep
Copy link
Member Author

clokep commented Aug 31, 2021

I suspect that we should skip these, like we did in sync for #7083.

@clokep clokep mentioned this issue Aug 31, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
A-Spaces Hierarchical organization of rooms S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore rooms with unknown room versions in the spaces summary. matrix-org/synapse
1 participant
@clokep