Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

(Optionally?) provide trace IDs in all requests, even if open tracing is disabled #11090

Open
DMRobertson opened this issue Oct 14, 2021 · 3 comments
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@DMRobertson
Copy link
Contributor

On #10854 I lamented that it was a bit painful to track down logs for a particular request in a sytest run. In my ideal scenario, each response would have a unique string which identifies the request, so we can grep through logs for that.

One option was to always generate the trace id reported with opentracing, even if opentracing was disabled. I like this approach, and it might make it easier to track future problems reported by clients. See #10854 (comment) and #10854 (comment)

Should probably convince ourselves that there aren't any privacy ramifications in doing this.

@DMRobertson DMRobertson added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Oct 14, 2021
@babolivier
Copy link
Contributor

Wasn't there also a proposal to include request IDs in headers? (I could swear I saw one but I can't seem to find it again)

@DMRobertson
Copy link
Contributor Author

There's #3373 but not sure if that's still valid. I suggested the request Ids in #10854, not sure if that's what you had in mind?

@babolivier
Copy link
Contributor

Aaah yes that was it, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

2 participants