Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

scripts-dev/complement.sh broke after 13f084e #11362

Closed
Bubu opened this issue Nov 16, 2021 · 2 comments · Fixed by #11368
Closed

scripts-dev/complement.sh broke after 13f084e #11362

Bubu opened this issue Nov 16, 2021 · 2 comments · Fixed by #11368
Assignees
@clokep
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@Bubu
Copy link
Contributor

Bubu commented Nov 16, 2021

Description

It seems like 13f084e broke the complement.sh script included here, it doesn't find any tests to run anymore:

Successfully built 41beaabb3d44
Successfully tagged complement-synapse:latest
no Go files in /home/bubu/projects/oss/synapse/complement-master

When manually reverting the changes to that file it works again (the actual tests fail somewhere down the line, but that another matter).

Steps to reproduce

  • run ./scripts-dev/complement.sh from an up-to-date synapse checkout
@clokep clokep self-assigned this Nov 17, 2021
@clokep clokep added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Nov 17, 2021
@clokep
Copy link
Member

clokep commented Nov 17, 2021

I need this for #10946 so I'm going to look at it.

@clokep clokep mentioned this issue Nov 17, 2021
Merged
@clokep
Copy link
Member

clokep commented Nov 17, 2021

Thanks for the report!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix running complement.sh script. matrix-org/synapse
2 participants
@Bubu @clokep