Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Imgur "GIFs" don't appear in URL previews #11563

Closed
nathanielcwm opened this issue Dec 13, 2021 · 8 comments · Fixed by #11669
Closed

Imgur "GIFs" don't appear in URL previews #11563

nathanielcwm opened this issue Dec 13, 2021 · 8 comments · Fixed by #11669
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Regression Something broke which worked on a previous release

Comments

@nathanielcwm
Copy link

Description

When an Imgur or Tenor link is sent into a chat using Element Web and it contains a "GIF" said video does not embed.

Steps to reproduce

  • Send or receive a link to an Imgur or Tenor "GIF" in chat
  • Observe that the embed just asks you to open a separate tab to open Imgur or Tenor instead of showing you the video.
    image
    image

Describe how what happens differs from what you expected.

I'd expect the video to be embedded and playable in chat but instead all that is embedded is some text asking for you to open imgur/tenor in a separate tab.

Version information

  • Homeserver:
    Matrix.org
  • Version:
    Whatever was on matrix.org on December 1st 2021

I was told that this was a homeserver bug when I reported it in element-hq/element-web#19970

Possible dupe of #1278 but I'm not certain.
@clokep
Copy link
Member

clokep commented Dec 13, 2021

Examples of the exact links you were using would be appreciated! 👍

I suspect #1278 is related though, yes.

@nathanielcwm
Copy link
Author

I believe it was Tenor and Imgur

lol the imgur link wasn't a "GIF", but it appears that was the one I used in the screenshot

@reivilibre reivilibre changed the title Imgur & Tenor "GIFs" don't embed Imgur & Tenor "GIFs" don't appear in URL previews Dec 14, 2021
@reivilibre reivilibre added S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Dec 14, 2021
@clokep
Copy link
Member

clokep commented Dec 14, 2021

Thanks, that's helpful! 👍

@blastrock
Copy link
Contributor

Note that this used to work before. I suspect #10814 to be the cause. I noticed it broke not long after that, but it may be unrelated.

@clokep clokep added the X-Regression Something broke which worked on a previous release label Dec 28, 2021
@blastrock blastrock mentioned this issue Jan 1, 2022
Merged
4 tasks
@nathanielcwm
Copy link
Author

Shouldn't this be reopened because Imgur was not fixed?

@nathanielcwm nathanielcwm changed the title Imgur & Tenor "GIFs" don't appear in URL previews Imgur "GIFs" don't appear in URL previews Jan 18, 2022
@clokep
Copy link
Member

clokep commented Jan 19, 2022

Shouldn't this be reopened because Imgur was not fixed?

They worked fine for me in my testing.

@nathanielcwm
Copy link
Author

Images do indeed work for me now, videos/GIFs don't appear to be working still.

@clokep
Copy link
Member

clokep commented Jan 26, 2022

Images do indeed work for me now, videos/GIFs don't appear to be working still.

Could also be due to #1278?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
S-Minor Blocks non-critical functionality, workarounds exist. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Regression Something broke which worked on a previous release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix preview of some gif URLs blastrock/synapse
4 participants
@clokep @blastrock @nathanielcwm @reivilibre