Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Improve performance of fetching bundled aggregations #11825

Closed
clokep opened this issue Jan 25, 2022 · 1 comment
Closed

Improve performance of fetching bundled aggregations #11825

clokep opened this issue Jan 25, 2022 · 1 comment
Assignees
Labels
A-Threads Threaded messages T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@clokep
Copy link
Member

clokep commented Jan 25, 2022

As detailed in the jaeger traces from #11611 the bundled aggregations code calculates the bundled aggregations for each event to be returned. To calculate the bundled aggregations for a single event is currently requires 6 queries (across 5 transactions).

For some APIs this is (e.g. /events only returns a single event), but /sync or /messages may return many events causing an explosion of queries.

Some of the fetched data is fairly simple and we should be able to fetch the data for multiple events at once, which should save queries. #11660 has some basic timing info that this might be an improvement, I imagine reducing the round-trips from a remote database would cause the gap to be further improved.

@clokep clokep added T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. A-Threads Threaded messages labels Jan 25, 2022
@clokep clokep self-assigned this Jan 25, 2022
@clokep
Copy link
Member Author

clokep commented Feb 11, 2022

I think I've done everything which is reasonable here? Unfortunately fetching the necessary info for m.reference and m.annotation relations looks quite hard to do as bulk queries.

I'm going to call this done since #11660 and #11752 both improved performance quite a bit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Threads Threaded messages T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

1 participant