Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Expose other worker types as console_scripts #11993

Closed
f0x52 opened this issue Feb 14, 2022 · 4 comments
Closed

Expose other worker types as console_scripts #11993

f0x52 opened this issue Feb 14, 2022 · 4 comments
Labels
A-Workers Problems related to running Synapse in Worker Mode (or replication) T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@f0x52
Copy link

f0x52 commented Feb 14, 2022

Currently only the synapse_homeserver (app.homeserver:main) and synapse_worker (app.generic_worker:main) binaries get generated and added to PATH by setuptools.
It would be nice to have executables in path to start the other types of workers as well, like pusher, appservice and federation_send.

This could be done through console_scripts definitions for each, or a more generic synapse_worker(s) script that allows you to choose the kind of worker you want to start with a flag.

@squahtx squahtx added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Feb 15, 2022
@richvdh
Copy link
Member

richvdh commented Feb 15, 2022

It'd be better to spend this work on getting rid of the dedicated types of workers (#10441).

@f0x52
Copy link
Author

f0x52 commented Feb 16, 2022

ah this is apparently not even needed at all, because since #6964 you can just execute all types with synapse_worker + the appropriate worker_app type in it's config, would be good if the documentation reflected that.

@f0x52
Copy link
Author

f0x52 commented Feb 16, 2022

the only current documentation I could really find on actually running a worker process was https://github.com/matrix-org/synapse/blob/develop/docs/systemd-with-workers/system/matrix-synapse-worker%40.service though :\

@richvdh
Copy link
Member

richvdh commented Feb 16, 2022

Agreed, the workers documentation is sorely lacking: #9072.

I'm going to go ahead and close this since it seems the original issue is resolved.

@richvdh richvdh closed this as completed Feb 16, 2022
@richvdh richvdh added the A-Workers Problems related to running Synapse in Worker Mode (or replication) label Feb 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Workers Problems related to running Synapse in Worker Mode (or replication) T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests

3 participants