Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Worker docs has 2 different endpoint regex for same endpoint #12229

Closed
olmari opened this issue Mar 15, 2022 · 3 comments · Fixed by #12243
Closed

Worker docs has 2 different endpoint regex for same endpoint #12229

olmari opened this issue Mar 15, 2022 · 3 comments · Fixed by #12243
Assignees
Labels
A-Docs things relating to the documentation A-Workers Problems related to running Synapse in Worker Mode (or replication) T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@olmari
Copy link
Contributor

olmari commented Mar 15, 2022

At https://github.com/matrix-org/synapse/blob/develop/docs/workers.md (master is same in this regard at the moment) there exist 2 different regex endpoints for some endpoints. Mostly those that is also mentioned in stream writers has more regex matches than the otherwise same endpoint given earlier in generic worker list..

For example under generic worker listing:

# Device requests
^/_matrix/client/(r0|v3|unstable)/sendToDevice/

and then later in stream writer to_device listing:

^/_matrix/client/(api/v1|r0|v3|unstable)/sendToDevice/
@clokep
Copy link
Member

clokep commented Mar 16, 2022

^/_matrix/client/(r0|v3|unstable)/sendToDevice/

Seems to be the correct one, as the endpoint is not registered for v1:

PATTERNS = client_patterns(
"/sendToDevice/(?P<message_type>[^/]*)/(?P<txn_id>[^/]*)$"
)

Would you mind making a PR with the fix? If not, I'll try to do it soon.

@clokep clokep added A-Docs things relating to the documentation A-Workers Problems related to running Synapse in Worker Mode (or replication) T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Mar 16, 2022
@olmari
Copy link
Contributor Author

olmari commented Mar 16, 2022

I could, if I can know are rest of the doubly mentioned endpoints in stream writers section without api/v1 correct for all of them :)

@clokep
Copy link
Member

clokep commented Mar 17, 2022

I ended up making a PR with the fixes: #12243.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Docs things relating to the documentation A-Workers Problems related to running Synapse in Worker Mode (or replication) T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants