Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Workers do not support knocks #12806

Closed
turt2live opened this issue May 20, 2022 · 1 comment · Fixed by #15133
Closed

Workers do not support knocks #12806

turt2live opened this issue May 20, 2022 · 1 comment · Fixed by #15133
Labels
P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@turt2live
Copy link
Member

The docs mention that ^/_matrix/client/(api/v1|r0|v3|unstable)/rooms/.*/(join|invite|leave|ban|unban|kick)$ and ^/_matrix/client/(api/v1|r0|v3|unstable)/join/ can be handled, but this is notably missing knock.

If /knock can be handled, can it be added to the docs please? 😇

@babolivier babolivier added A-Docs things relating to the documentation T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels May 20, 2022
@dklimpel
Copy link
Contributor

dklimpel commented Aug 3, 2022

At the moment /knock can not be handled by generic_worker.

voip.register_servlets(self, resource)
push_rule.register_servlets(self, resource)
versions.register_servlets(self, resource)
profile.register_servlets(self, resource)
sync.register_servlets(self, resource)
events.register_servlets(self, resource)
room.register_servlets(self, resource, is_worker=True)
room.register_deprecated_servlets(self, resource)
initial_sync.register_servlets(self, resource)
room_batch.register_servlets(self, resource)
room_keys.register_servlets(self, resource)
tags.register_servlets(self, resource)
account_data.register_servlets(self, resource)
receipts.register_servlets(self, resource)
read_marker.register_servlets(self, resource)
sendtodevice.register_servlets(self, resource)
user_directory.register_servlets(self, resource)
presence.register_servlets(self, resource)

There is missing the import of knock and something like knock.register_servlets(self, resource)

@richvdh richvdh changed the title Worker docs: no mention of knocks Workers do not support knocks Aug 3, 2022
@richvdh richvdh added T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches and removed A-Docs things relating to the documentation T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches labels Aug 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants