Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Clear out empty event_push_summary rows #13875

Open
clokep opened this issue Sep 22, 2022 · 0 comments
Open

Clear out empty event_push_summary rows #13875

clokep opened this issue Sep 22, 2022 · 0 comments
Labels
A-Threads Threaded messages O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@clokep
Copy link
Member

clokep commented Sep 22, 2022

After #13776 we generate a row in event_push_summary per (user, room, thread). If a receipt marks a thread as completely read then the summary is (somewhat) useless as the notif_count and unread_count would be 0.

It might make sense to clean these up eventually to avoid the table growing too large.

There's some conversation about this at #13776 (comment).
@clokep clokep added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. A-Threads Threaded messages O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Sep 22, 2022
@clokep clokep mentioned this issue Sep 22, 2022
Merged
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Threads Threaded messages O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clokep