Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Complement flake(?): GET_/rooms/:room_id/aliases_lists_aliases #14183

Closed
DMRobertson opened this issue Oct 14, 2022 · 9 comments · Fixed by matrix-org/complement#521
Closed

Complement flake(?): GET_/rooms/:room_id/aliases_lists_aliases #14183

DMRobertson opened this issue Oct 14, 2022 · 9 comments · Fixed by matrix-org/complement#521
Assignees
@DMRobertson
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact Z-Flake Tests that give intermittent failures

Comments

@DMRobertson
Copy link
Contributor

DMRobertson commented Oct 14, 2022 •
edited
Loading

https://github.com/matrix-org/synapse/actions/runs/3249032216/jobs/5331241845

Edit(dmr): I am trying to reproduce this with

WORKERS=1 POSTGRES=1 COMPLEMENT_DIR=../complement scripts-dev/complement.sh -run 'TestRoomAlias/.*aliases_lists_aliases'

and have manually upped the replication torture setting in Synapse's source.
@DMRobertson DMRobertson added T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Flake Tests that give intermittent failures Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact labels Oct 14, 2022
@DMRobertson DMRobertson mentioned this issue Oct 14, 2022
Merged
4 tasks
@DMRobertson
Copy link
Contributor Author

https://github.com/matrix-org/synapse/actions/runs/3250081130/jobs/5333349627

@DMRobertson
Copy link
Contributor Author

Why are we suddenly seeing this today?

https://github.com/matrix-org/synapse/actions/runs/3251269844/jobs/5336107983

@DMRobertson
Copy link
Contributor Author

https://github.com/matrix-org/synapse/actions/runs/3252498613/jobs/5338825082

seems to be a worker-specific failure(?)

@DMRobertson
Copy link
Contributor Author

https://github.com/matrix-org/synapse/actions/runs/3258600088/jobs/5350813055

@DMRobertson DMRobertson mentioned this issue Oct 17, 2022
Closed
@DMRobertson DMRobertson self-assigned this Oct 17, 2022
@DMRobertson
Copy link
Contributor Author

Test from matrix-org/complement#266.

Sytest still exists here: https://github.com/matrix-org/sytest/blame/da1c9e221f998b1d50214b9dd8ab18eb3804d57a/tests/10apidoc/32room-alias.pl#L52 and was deflaked matrix-org/sytest#1056. The deflaking was not ported to complement.

@DMRobertson
Copy link
Contributor Author

Indeed, as Rich notes in matrix-org/sytest#1055 (comment):

the problem is that the request to set the alias now goes to the master, while the query goes to the client_reader.

@DMRobertson
Copy link
Contributor Author

(I wonder if #14165 might have exposed this?)

@DMRobertson DMRobertson mentioned this issue Oct 17, 2022
Merged
@DMRobertson
Copy link
Contributor Author

I've worked around this with a retry loop, but as noted here, the underlying problem is that Synapse (as an aggregation of workers) isn't offering read-after-write consistency here.

@DMRobertson DMRobertson mentioned this issue Oct 17, 2022
Open
@DMRobertson
Copy link
Contributor Author

https://github.com/matrix-org/synapse/actions/runs/3273203305/jobs/5385186367

@DMRobertson DMRobertson mentioned this issue Oct 18, 2022
Merged
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DMRobertson DMRobertson

Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Dev-Wishlist Makes developers' lives better, but doesn't have direct user impact Z-Flake Tests that give intermittent failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deflake GET /rooms/:room_id/aliases lists aliases matrix-org/complement
1 participant
@DMRobertson