Regression when login after deactivation (no more M_USER_DEACTIVATED code)

[BillCarsonFr]

Android CI is failing when running deactivate account test

With previous synapse version, the test was getting a M_USER_DEACTIVATED error, and now (since 1.85.0?) the error is:

{"errcode":"M_FORBIDDEN","error":"Invalid username or password"}

Is it expected?

[dklimpel]

This was probably part of:

• Consolidate logic to check for deactivated users. #15634
• Do not allow deactivated users to login with JWT #15624

[jamazi]

mautrix/telegram#922 cannot login after 1.85

[clokep]

I think the way to fix this is to move the check for deactivated accounts (from #15634) earlier in the process (so before we check the accounts password).