Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

matrix.org repeatedly trying to backfill HQ from jki.re #2839

Open
richvdh opened this issue Jan 30, 2018 · 3 comments
Open

matrix.org repeatedly trying to backfill HQ from jki.re #2839

richvdh opened this issue Jan 30, 2018 · 3 comments
Labels
A-Federation A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) A-Performance Performance, both client-facing and admin-facing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@richvdh
Copy link
Member

richvdh commented Jan 30, 2018

somebody was using nheko which was (for some reason) desperately trying to scroll back in matrix HQ, making the same request every second for 20 minutes or so. For each request matrix.org then tried to backfill from jki.re.
@richvdh
Copy link
Member Author

richvdh commented Jan 30, 2018

(each request also took 300ms of CPU time, which was the real problem, since that meant this one user was monopolising 30% of synapse's bandwidth)

@ara4n
Copy link
Member

ara4n commented Feb 6, 2018

So the problems here are:

  • It's not roundrobbining when it backfills
  • It shouldn't be repeatedly requesting the same thing anyway - surely we should be caching it or dup-suppressing it.
  • The requests shouldn't be so heavy even then; 300ms is massive.

@ara4n ara4n added z-bug (Deprecated Label) p1 A-Performance Performance, both client-facing and admin-facing z-major (Deprecated Label) labels Feb 6, 2018
@MadLittleMods MadLittleMods added A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) A-Federation labels Aug 25, 2022
@MadLittleMods
Copy link
Contributor

Seems like the same problem as #2504 (300ms CPU time backfill from jki.re)

@DMRobertson DMRobertson added S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Performance A-Performance Performance, both client-facing and admin-facing and removed z-bug (Deprecated Label) z-p1 A-Performance Performance, both client-facing and admin-facing z-major (Deprecated Label) labels Aug 25, 2022
@matrixbot matrixbot mentioned this issue Dec 21, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Federation A-Messages-Endpoint /messages client API endpoint (`RoomMessageListRestServlet`) (which also triggers /backfill) A-Performance Performance, both client-facing and admin-facing O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Major functionality / product severely impaired, no satisfactory workaround. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MadLittleMods @ara4n @richvdh @DMRobertson