Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

synapse allows you to omit the from param to /messages, which is non-spec-compliant #5538

Closed
richvdh opened this issue Jun 24, 2019 · 4 comments
Closed

synapse allows you to omit the from param to /messages, which is non-spec-compliant #5538

richvdh opened this issue Jun 24, 2019 · 4 comments
Labels
A-Spec-Compliance places where synapse does not conform to the spec S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@richvdh
Copy link
Member

richvdh commented Jun 24, 2019

Per https://matrix.org/docs/spec/client_server/r0.5.0#get-matrix-client-r0-rooms-roomid-messages, from is mandatory, but apparently riot-android does not (always?) set it.
@erikjohnston erikjohnston mentioned this issue Jun 24, 2019
Merged
@neilisfragile neilisfragile added z-p2 (Deprecated Label) A-Spec-Compliance places where synapse does not conform to the spec labels Jun 27, 2019
@ShadowJonathan ShadowJonathan mentioned this issue Feb 24, 2021
Closed
@ShadowJonathan
Copy link
Contributor

(Updated spec link, for reference: https://matrix.org/docs/spec/client_server/latest#get-matrix-client-r0-rooms-roomid-messages)

@clokep clokep added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. and removed z-p2 (Deprecated Label) labels Feb 24, 2021
@deepbluev7
Copy link
Contributor

Duplicate of #1445, I'd say.

@richvdh richvdh mentioned this issue Dec 13, 2021
Closed
@clokep clokep mentioned this issue Dec 14, 2021
Merged
@clokep
Copy link
Member

clokep commented Dec 14, 2021

See also MSC3567 which looks to standardize the behavior in Synapse.

@clokep
Copy link
Member

clokep commented Jan 18, 2022 •
edited
Loading

This behavior is now spec compliant, per MSC3567.

@clokep clokep closed this as completed Jan 18, 2022
@clokep clokep mentioned this issue Mar 7, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
A-Spec-Compliance places where synapse does not conform to the spec S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@neilisfragile @clokep @richvdh @deepbluev7 @ShadowJonathan