-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Move admin endpoints into separate files #6308
Move admin endpoints into separate files #6308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. You'll need to do a couple changes to fix the CI though.
First, you'll need to pull in the latest changes from develop to fix a pep 517 issue with python on the sample config script.
Next, you'll want to run ./scripts-dev/lint.sh
to correct isort
and any other linting issues. Make sure you've got your linting tools up to date as well. For instance, the version of black that we use is 19.10b0
(I don't think the others have changed recently).
Finally, you'll need to include a changelog file. I recommend a .misc
extension for it.
@awesome-manuel are you still around? |
Yes. The PR was rebased to |
ea1e168
to
9bb6e87
Compare
@anoadragon453 can you trigger buildkite please? |
@awesome-manuel I triggered it; it should run automatically in future. Looks like the CI is very unhappy about something - could you investigate? |
mostly |
Strange, since |
0b0e53d
to
9b03f7c
Compare
Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>
9b03f7c
to
0ac3a26
Compare
@richvdh @anoadragon453 everything is fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you for you contribution!
* commit '4f5ca455b': Move admin endpoints into separate files (#6308)
@richvdh @erikjohnston this is a prerequisite for #5925
Pull Request Checklist