This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Use BSD-compatible in-place editing for sed. #6887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
force-pushed
the
clokep/lint-sed-bsd
branch
from
3a5b4f2 to
e9daed8
Compare
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit 'ba547ec3a': Use BSD-compatible in-place editing for sed. (#6887)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the linting scripts the use of sed is not compatible with BSD's sed (which is what macOS uses unless a different version is installed).
This StackOverflow has a good explanation of the differences.
Without this change I end up with a
docs/sample_config.yaml-Efile in my directory each time I run the linting script.I have not tested this with GNU sed, but I'm fairly certain it will work! You can check which version you have via the man pages (
man sed). (Weirdly my version doesn't seem to have a--versionflag...)