This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Optimise some references to hs.config #7546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
looks like there are some tests to fix... |
These are surprisingly expensive, and we only really need to do them at startup.
richvdh
force-pushed
the
rav/inline_config_refs
branch
from
7834840 to
fd19929
Compare
|
@richvdh I was able to fix most of the tests, I had to split one |
clokep
approved these changes
May 22, 2020
phil-flex
pushed a commit
to phil-flex/synapse
that referenced
this pull request
Jun 16, 2020
These are surprisingly expensive, and we only really need to do them at startup.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are surprisingly expensive, and we only really need to do them at startup.