Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Replace device_27_unique_idx bg update with a fg one #7562

Merged
merged 2 commits into from
May 26, 2020

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented May 22, 2020

The bg update never managed to complete, because it kept being interrupted by
transactions which want to take a lock.

Just doing it in the foreground isn't that bad, and is a good deal simpler.

Fixes #7437.

The bg update never managed to complete, because it kept being interrupted by
transactions which want to take a lock.

Just doing it in the foreground isn't that bad, and is a good deal simpler.
@richvdh richvdh requested a review from a team May 22, 2020 21:57
UPGRADE.rst Outdated Show resolved Hide resolved
@richvdh richvdh requested review from clokep and a team and removed request for clokep May 22, 2020 22:36
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty confident this is fine! I'd almost like set a set of tests run with both deltas applied to ensure this won't break matrix.org...but that's not really feasible, (nor makes sense in the long term).

@erikjohnston erikjohnston merged commit edd9a72 into develop May 26, 2020
@erikjohnston erikjohnston deleted the rav/upsert_for_device_list2 branch May 26, 2020 10:43
phil-flex pushed a commit to phil-flex/synapse that referenced this pull request Jun 16, 2020
The bg update never managed to complete, because it kept being interrupted by
transactions which want to take a lock.

Just doing it in the foreground isn't that bad, and is a good deal simpler.
babolivier pushed a commit that referenced this pull request Sep 1, 2021
…dinsic-release-v1.14.x

* 'release-v1.14.0' of github.com:matrix-org/synapse: (108 commits)
  Fix typo in PR link
  Update debian changelog
  1.14.0
  Improve changelog wording
  1.14.0rc2
  Fix sample config docs error (#7581)
  Fix up comments
  Fix specifying cache factors via env vars with * in name. (#7580)
  Don't apply cache factor to event cache. (#7578)
  Ensure ReplicationStreamer is always started when replication enabled. (#7579)
  Remove the changes to the debian changelog
  Not full release yet, this is rc1
  Merge event persistence move changelog entries
  More changelog fix
  Changelog fixes
  1.14.0
  Replace device_27_unique_idx bg update with a fg one (#7562)
  Fix incorrect exception handling in KeyUploadServlet.on_POST (#7563)
  Fix recording of federation stream token (#7564)
  Simplify reap_monthly_active_users (#7558)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

background update in #7429 doesn't work
3 participants