Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add note in CONTRIBUTING.md about ways to run the mypy type checker. #8601

Closed
ShadowJonathan opened this issue Oct 20, 2020 · 1 comment · Fixed by #8633
Closed

Add note in CONTRIBUTING.md about ways to run the mypy type checker. #8601

ShadowJonathan opened this issue Oct 20, 2020 · 1 comment · Fixed by #8633
Labels
A-Docs things relating to the documentation Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label)

Comments

@ShadowJonathan
Copy link
Contributor

Per @clokep's comment, maybe adding something along the following lines to CONTRIBUTING.md would be nice:

  • Something about being able to use tox -e mypy to do a isolated lint check.

  • Something about being able to do pip install -e .[mypy] to install the right mypy version in venv, to be able to execute mypy by itself (which can be faster than running it through tox)

@clokep clokep added A-Docs things relating to the documentation Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label) labels Oct 20, 2020
@devanshushah1
Copy link

Per @clokep's comment, maybe adding something along the following lines to CONTRIBUTING.md would be nice:

  • Something about being able to use tox -e mypy to do a isolated lint check.
  • Something about being able to do pip install -e .[mypy] to install the right mypy version in venv, to be able to execute mypy by itself (which can be faster than running it through tox)

i agree

@clokep clokep linked a pull request Oct 27, 2020 that will close this issue
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Docs things relating to the documentation Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants