Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

SSO-over-UIA flow is ugly and not mobile-friendly #9171

Closed
richvdh opened this issue Jan 20, 2021 · 0 comments
Closed

SSO-over-UIA flow is ugly and not mobile-friendly #9171

richvdh opened this issue Jan 20, 2021 · 0 comments
Labels
S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.

Comments

@richvdh
Copy link
Member

richvdh commented Jan 20, 2021

  1. It starts with something nice in the client app, like:

    image

    That bit is fine.

  2. After you click "Single Sign On", you get taken to a new tab, which looks like:

    image

    That is (a) ugly, (b) not mobile-friendly, (c) we don't seem to know if "sign-on" is hyphenated or not.

    For context, MSC2454 explains why this page is required.

  3. Clicking "reauthenticate with single sign-on" takes you to the SSO provider's pages, which are outside our control and probably fine.

  4. Then when you finish SSO you end up back at a page which looks like:

    image

    ... which is also ugly and not mobile-friendly. It's also missing a full stop. It's worth noting that the intention is that the user should never see this page, but various bugs (UIA-over-SSO leaves you marooned in a "please close this tab" tab element-hq/element-web#16219, https://github.com/matrix-org/matrix-doc/issues/2977) mean that is not the case today.

  5. There are also some error pages a user might see along the way.

    For example, a generic error page:

    image

    Or, "you seem to have logged into your SSO provider with a different user to what we expected":

    image

    In both cases we do a poor job of explaining to the user how they should proceed. Oh and now single-sign-on has two hyphens!

There's a general theme here that these templates are very basic and would benefit from some wordsmithing and design. However, note that they are part of the homeserver, not the client, so Element branding is inappropriate. For matrix.org, we could consider customising the default templates with Matrix branding, but it would be nice to consider whether we can improve the default templates that are shipped as part of the Synapse package so that all deployments can benefit from the improvements.

@anoadragon453 anoadragon453 added S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. labels Jan 26, 2021
@richvdh richvdh closed this as completed in e5d70c8 Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues.
Projects
None yet
Development

No branches or pull requests

2 participants