From 01be03c71d0dfd087c7171600611e2ac7f76aa0f Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Tue, 7 Apr 2020 16:18:37 +0100 Subject: [PATCH 1/3] Make it clearer to the user that they haven't overridden onLogin/onRegister --- synapse/static/client/login/js/login.js | 2 +- synapse/static/client/register/js/register.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/synapse/static/client/login/js/login.js b/synapse/static/client/login/js/login.js index debe46437134..cff99da18bd1 100644 --- a/synapse/static/client/login/js/login.js +++ b/synapse/static/client/login/js/login.js @@ -128,7 +128,7 @@ matrixLogin.password_login = function() { matrixLogin.onLogin = function(response) { // clobber this function - console.log("onLogin - This function should be replaced to proceed."); + console.warn("onLogin - This function should be replaced to proceed."); console.log(response); }; diff --git a/synapse/static/client/register/js/register.js b/synapse/static/client/register/js/register.js index b62763a2934d..445cb840ff50 100644 --- a/synapse/static/client/register/js/register.js +++ b/synapse/static/client/register/js/register.js @@ -113,5 +113,5 @@ matrixRegistration.signUp = function() { matrixRegistration.onRegistered = function(hs_url, user_id, access_token) { // clobber this function - console.log("onRegistered - This function should be replaced to proceed."); + console.warn("onRegistered - This function should be replaced to proceed."); }; From cc5a0a59cf3e9e2c1270e65454192783f81cda69 Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Tue, 7 Apr 2020 16:36:35 +0100 Subject: [PATCH 2/3] Add changelog --- changelog.d/7237.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/7237.misc diff --git a/changelog.d/7237.misc b/changelog.d/7237.misc new file mode 100644 index 000000000000..92e67ea31fb9 --- /dev/null +++ b/changelog.d/7237.misc @@ -0,0 +1 @@ +Change log line that told user to implement onLogin/onRegister fallback js functions to a warning, instead of an info, so it's more visible. \ No newline at end of file From e7b79d254b99e67eea67fa66cdddd9ed84a34ced Mon Sep 17 00:00:00 2001 From: Andrew Morgan Date: Thu, 9 Apr 2020 12:11:41 +0100 Subject: [PATCH 3/3] Remove access-token spilling log line --- synapse/static/client/login/js/login.js | 1 - 1 file changed, 1 deletion(-) diff --git a/synapse/static/client/login/js/login.js b/synapse/static/client/login/js/login.js index cff99da18bd1..e9356250e9bc 100644 --- a/synapse/static/client/login/js/login.js +++ b/synapse/static/client/login/js/login.js @@ -129,7 +129,6 @@ matrixLogin.password_login = function() { matrixLogin.onLogin = function(response) { // clobber this function console.warn("onLogin - This function should be replaced to proceed."); - console.log(response); }; var parseQsFromUrl = function(query) {