Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pending transactions to TransactionHistory view #72

Merged

Conversation

santteegt
Copy link

Description

Add pending transactions to TransactionHistory view. The feature is included for ETH, ERC20 or xDAI transactions. Implementation approach includes:

  • Store all sent transactions on the ETHTransactionModel with isPending=true.
  • When the TransactionHistory view refreshes:
  1. fetch pending ETHTransactionModel records. Then for each transaction:
  2. Get transaction details using txHash and web3
  3. Update the record status on those that were already confirmed
  4. trxs that are still pending are appended to the view list

Refs #56

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Add pending transactions to TransactionHistory view
@BaldyAsh BaldyAsh self-requested a review April 17, 2019 14:13
Copy link
Contributor

@BaldyAsh BaldyAsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@santteegt hi! Looked at the code, everything should work fine. I'll run the project from your branch and if everything works, then I will approve this PR

Copy link
Contributor

@BaldyAsh BaldyAsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @santteegt! It works, I approve it. Thank you for your work! :)

@BaldyAsh BaldyAsh merged commit a5f8fe3 into matter-labs-archive:w3s2.1.3update Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants